-
Notifications
You must be signed in to change notification settings - Fork 569
Adding INDEXED_SEARCH_INDEXER env var #1208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The backport to To backport this PR manually, you can either: Via the sg toolUse the sg backport -r 6.2.x -p 1208Via your terminalTo backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-6.2.x 6.2.x
# Navigate to the new working tree
cd .worktrees/backport-6.2.x
# Create a new branch
git switch --create backport-1208-to-6.2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ba714c58a6e06742919f3077daa3bf114ef97c17
# Push it to GitHub
git push --set-upstream origin backport-1208-to-6.2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-6.2.xIf you encouter conflict, first resolve the conflict and stage all files, then run the commands below: git cherry-pick --continue
# Push it to GitHub
git push --set-upstream origin backport-1208-to-6.2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-6.2.x
Once the pull request has been created, please ensure the following:
|
|
The backport to To backport this PR manually, you can either: Via the sg toolUse the sg backport -r 6.3.x -p 1208Via your terminalTo backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-6.3.x 6.3.x
# Navigate to the new working tree
cd .worktrees/backport-6.3.x
# Create a new branch
git switch --create backport-1208-to-6.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ba714c58a6e06742919f3077daa3bf114ef97c17
# Push it to GitHub
git push --set-upstream origin backport-1208-to-6.3.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-6.3.xIf you encouter conflict, first resolve the conflict and stage all files, then run the commands below: git cherry-pick --continue
# Push it to GitHub
git push --set-upstream origin backport-1208-to-6.3.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-6.3.x
Once the pull request has been created, please ensure the following:
|
…nvs (#1209) Add `INDEXED_SEARCH_INDEXER` to sourcegraph-frontend-internal service ENVs. Follow up to #1208 ### Checklist <!-- Kubernetes and Docker Compose MUST be kept in sync. You should not merge a change here without a corresponding change in the other repository, unless it truly is specific to this repository. If uneeded, add link or explanation of why it is not needed here. --> * [ ] Sister [deploy-sourcegraph](https://github.com/sourcegraph/deploy-sourcegraph) change: * [ ] Sister [customer-replica](https://github.com/sourcegraph/deploy-sourcegraph-docker-customer-replica-1) change (if necessary, for any changes affecting pure-docker or configuration): * [ ] All images have a valid tag and SHA256 sum ### Test plan CI <!-- As part of SOC2/GN-104 and SOC2/GN-105 requirements, all pull requests are REQUIRED to provide a "test plan". A test plan is a loose explanation of what you have done or implemented to test this, as outlined in our Testing principles and guidelines: https://docs.sourcegraph.com/dev/background-information/testing_principles Write your test plan here after the "Test plan" header. -->
Adding the new
INDEXED_SEARCH_INDEXERenv varChecklist
Test plan
Tested on test instance